[PATCH] D44468: [AMDGPU] For OS type AMDPAL, fixed scratch on compute shader

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

LGTM.

In https://reviews.llvm.org/D44468#1050348, @tpr wrote:

> What's the protocol for a fix to a change that I had to revert due to test failure? Does it need to come back to review here? Or should I just have landed it?


I don't believe there are completely hard rules. Personally, I'd say it depends on (a) how invasive the fix is and (b) how quickly you find it. In this particular case, I'd say the change is small enough that you could have just landed it. I'd go further and say that if the problem is so obvious that you realize it within a very short time of receiving the failure notifications, you might just commit the fix without reverting. Generally you should run the lit tests yourself locally though, to reduce the chances of this happening in the first place.


Repository:
  rL LLVM

https://reviews.llvm.org/D44468