[PATCH] D45066: [Polly] [ScopInfo] Remove bail out condition in buildMinMaxAccess()

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

Some more analysis from my side:

1. Due to the approximation of the of the hull, `Set.lexmin_pw_multi_aff()` can fail not only because if a quota exceeds, but because the set is unbounded: `isl_error_invalid`

2. Code assumes that because there is no isl_error_quota, the code thinks is succeeds, but results in a NULL entry which later code does not expects.

3. the additional error with affine_hull also occur with simple_hull, just a lot less often.

4. Some other errors occur, but only leed to the output: `IMPLEMENTATION ERROR: Unhandled error state`. This phenomenon has already been reported by Eli.


Repository:
  rPLO Polly

https://reviews.llvm.org/D45066