[PATCH] D45122: [DebugInfo] Add a new DI flag to record if a C++ record is a trivial type

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Apr 1 12:15:38 PDT 2018


probinson added a comment.

Is "trivial" the right flag?  In DWARF v5 there is a "defaulted" attribute, which also distinguishes between in-class and out-of-class defaulting.  I'd rather not have a bunch of different flags meaning only slightly different things if we can come up with a more coherent way to track the information we need.



================
Comment at: llvm/IR/DebugInfoFlags.def:49
+HANDLE_DI_FLAG((1 << 24), Trivial)
+HANDLE_DI_FLAG((1 << 25), FixedEnum)
 
----------------
Is there some reason FixedEnum wants to be last?


Repository:
  rL LLVM

https://reviews.llvm.org/D45122





More information about the llvm-commits mailing list