[PATCH] D44748: Track whether the size of a MemoryLocation is precise

[Nuno Lopes via Phabricator via llvm-commits]

nlopes added a comment.

LGTM, but I would wait for another review due to the size of the change.



================
Comment at: lib/Analysis/BasicAliasAnalysis.cpp:1716
   if (O1 == O2)
-    if (V1Size != MemoryLocation::UnknownSize &&
-        V2Size != MemoryLocation::UnknownSize &&
-        (isObjectSize(O1, V1Size, DL, TLI) ||
-         isObjectSize(O2, V2Size, DL, TLI)))
+    if (V1Size != MemoryLocation::UnknownSize && V1Size.isPrecise() &&
+        V2Size != MemoryLocation::UnknownSize && V2Size.isPrecise() &&
----------------
isPrecise() should be enough since UnknownSize() isn't precise. This pattern appears a couple more times.


https://reviews.llvm.org/D44748