[PATCH] D44847: [profile] Fix value profile runtime merging issues

[Rong Xu via Phabricator via llvm-commits]

xur added inline comments.


================
Comment at: lib/profile/InstrProfilingMerge.c:40
 
+/* Returns the profile file size without value profiles.  */
+COMPILER_RT_VISIBILITY
----------------
davidxl wrote:
> There is an existing interface for this:
> 
> __llvm_profile_get_size_for_buffer_internal
using that API needs to pass the begin and end address for each section.
Here we use all the counters recorded in the header.


================
Comment at: lib/profile/InstrProfilingValue.c:157
     if (TargetValue == CurVNode->Value) {
-      CurVNode->Count++;
+      CurVNode->Count = CountValue;
       return;
----------------
davidxl wrote:
> += CountValue ?
yes. I cannot believe this is not caught by all the tests.


https://reviews.llvm.org/D44847