[PATCH] D44847: [profile] Fix value profile runtime merging issues

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 30 14:28:46 PDT 2018


davidxl added inline comments.


================
Comment at: lib/profile/InstrProfilingMerge.c:40
 
+/* Returns the profile file size without value profiles.  */
+COMPILER_RT_VISIBILITY
----------------
There is an existing interface for this:

__llvm_profile_get_size_for_buffer_internal


================
Comment at: lib/profile/InstrProfilingValue.c:157
     if (TargetValue == CurVNode->Value) {
-      CurVNode->Count++;
+      CurVNode->Count = CountValue;
       return;
----------------
+= CountValue ?


https://reviews.llvm.org/D44847





More information about the llvm-commits mailing list