[PATCH] D45026: [DebugInfo] Add bitcode reader/writer for DILabel metadata.

Wei-Ren Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 30 08:00:40 PDT 2018


chenwj added a comment.

I am not sure which fields of DILabel are required or optional, please double check yourself.



================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1652
+  case bitc::METADATA_LABEL: {
+    if (Record.size() < 4)
+      return error("Invalid record");
----------------
According [[ https://reviews.llvm.org/D45025 | D45025]], should be `Record.size() != 5`?


Repository:
  rL LLVM

https://reviews.llvm.org/D45026





More information about the llvm-commits mailing list