[PATCH] D44464: allow custom OptBisect classes set to LLVMContext

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 30 04:00:19 PDT 2018


fedor.sergeev added inline comments.


================
Comment at: lib/IR/LLVMContextImpl.h:1362
   /// analysis.
   OptPassGate &getOptPassGate();
+
----------------
yrouban wrote:
> andrew.w.kaylor wrote:
> > I missed this in the last review. This function should be const.
> D44821 did not change this. LLVMContextImpl::getOptBisect() used to be non-const.
> 
I agree with Andrew, it is natural to have it const.


https://reviews.llvm.org/D44464





More information about the llvm-commits mailing list