[PATCH] D41330: [X86] Reduce Store Forward Block issues in HW

[Lama via Phabricator via llvm-commits]

lsaba marked 10 inline comments as done.
lsaba added inline comments.


================
Comment at: lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp:345
+  unsigned BlockLimit = 0;
+  unsigned InspectionLimit = X86AvoidSFBInspectionLimit;
+  for (MachineBasicBlock::iterator LI = LoadInst,
----------------
craig.topper wrote:
> Why do we need InspectionLimit? Can't we use x86AvoidSFBInspectionLimit everywhere? Or at least make InspectionLimit const. Naively it looks like the limit might be changed in the function.
I did it for readability purposes only


================
Comment at: lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp:347
+  for (MachineBasicBlock::iterator LI = LoadInst,
+                                   BB = LoadInst->getParent()->begin();
+       LI != BB; --LI) {
----------------
craig.topper wrote:
> This won't visit the first instruction in the block. And it visits LoadInst. Is that intended?
Nope, fixed.


https://reviews.llvm.org/D41330