[PATCH] D44785: Lowering x86 adds/addus/subs/subus intrinsics (llvm part)

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/IR/AutoUpgrade.cpp:73
   // point.
-  if (Name=="ssse3.pabs.b.128" || // Added in 6.0
+  if (Name.startswith("sse2.padds") || // Added in 6.0
+      Name.startswith("sse2.paddus") || // Added in 6.0
----------------
The next release will be 7.0 not 6.0.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:34015
+  } // For architectures without SSE4.1 and vectors of type v4i32 ISD::SMAX is not legal.
+    // For example in SSE2 saturation of v8i16 vector extends the vector to v8i32 and splits it
+    // to two independent registers with v4i32 which causes failure of SMAX detection.
----------------
Is this line longer than 80 characters?


https://reviews.llvm.org/D44785