[PATCH] D44986: Initialize Elf header and Program Header to Zero

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/test/ELF/elf-header-initialized.s:1
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-pc-linux %s -o %t.o
----------------
I'd name this file just "elf-header.s".


================
Comment at: lld/test/ELF/elf-header-initialized.s:4
+# RUN: ld.lld %t.o -o %t1
+# RUN: llvm-readobj -file-headers -r %t1 | FileCheck %s
+
----------------
Please remove '-r' as you are not using it.


================
Comment at: lld/test/ELF/elf-header-initialized.s:7
+# RUN: ld.lld %t.o -no-rosegment -o %t2
+# RUN: llvm-readobj -file-headers -r %t2 | FileCheck %s
+
----------------
Ditto


https://reviews.llvm.org/D44986