[PATCH] D45000: [LNT] fix some typos/dead code

Danila Malyutin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 28 14:08:28 PDT 2018


danilaml created this revision.
danilaml added reviewers: MatzeB, cmatthews, kristof.beyls.
Herald added a subscriber: llvm-commits.

Fix some typos/dead/unreachable code I've noticed while going through the LNT.


Repository:
  rL LLVM

https://reviews.llvm.org/D45000

Files:
  lnt/server/ui/views.py
  lnt/tests/nt.py
  lnt/util/ServerUtil.py


Index: lnt/util/ServerUtil.py
===================================================================
--- lnt/util/ServerUtil.py
+++ lnt/util/ServerUtil.py
@@ -66,8 +66,6 @@
         print "error:", result_data
         return
 
-    return reply
-
 
 def submitFileToInstance(path, file, select_machine=None, merge_run=None):
     # Otherwise, assume it is a local url and submit to the default database
Index: lnt/tests/nt.py
===================================================================
--- lnt/tests/nt.py
+++ lnt/tests/nt.py
@@ -1397,7 +1397,6 @@
         if server_reply.get('error', None):
             logger.warning("Server returned an error:" + server_reply['error'])
         fatal("No Server results. Cannot do reruns.")
-        logging.fatal()
     # Holds the combined local and server results.
     collated_results = dict()
 
Index: lnt/server/ui/views.py
===================================================================
--- lnt/server/ui/views.py
+++ lnt/server/ui/views.py
@@ -1367,7 +1367,7 @@
         # Compute comparison results for each machine.
         row.extend((runinfo.get_run_comparison_result(
                         run, baseline, test_id, field,
-                        ts.Sample.get_hash_of_Binary_field),
+                        ts.Sample.get_hash_of_binary_field),
                     run.id)
                    for baseline, run in machine_run_info)
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45000.140134.patch
Type: text/x-patch
Size: 1401 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180328/97afad71/attachment.bin>


More information about the llvm-commits mailing list