[PATCH] D43501: [lit] Implement 'cat' command for internal shell

[Alex Bradbury via Phabricator via llvm-commits]

asb added a comment.

Could you please post the change as a separate revision, as a diff vs what was committed?

I think the correct fix would be to alter the code so it works in both Python 2 and Python 3, given that lit is compatible with Python 3 otherwise.

Should this builtin be implemented so that stdout is re-opened as binary? Won't undesired CRLF translation happen on Windows with the current implementation? (Honest question - I could be wrong!)


https://reviews.llvm.org/D43501