[PATCH] D43501: [lit] Implement 'cat' command for internal shell

Chamal De Silva via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 27 19:45:46 PDT 2018


chamalsl updated this revision to Diff 140033.
chamalsl added a comment.

This is a speculative fix for test failiure on ArchLinux , since I am unable to recreate the exact python environment on my Ubuntu machine. According to email sent by Alex Bradbury, on ArchLinux default python version is set to Python 3. But lit.py is run using /usr/bin/python2.7.

So I used 'sys.executable' instead of 'python' to execute built-in commands. So I am hoping 'sys.executable' will point  to python2.7 since lit.py is run using python2.7.


https://reviews.llvm.org/D43501

Files:
  utils/lit/lit/TestRunner.py
  utils/lit/lit/builtin_commands/cat.py
  utils/lit/tests/Inputs/shtest-shell/cat-error-0.txt
  utils/lit/tests/Inputs/shtest-shell/cat-error-1.txt
  utils/lit/tests/Inputs/shtest-shell/cat_nonprinting.bin
  utils/lit/tests/Inputs/shtest-shell/valid-shell.txt
  utils/lit/tests/max-failures.py
  utils/lit/tests/shtest-shell.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43501.140033.patch
Type: text/x-patch
Size: 11244 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180328/261c3cc6/attachment.bin>


More information about the llvm-commits mailing list