[PATCH] D44669: Use local symbols for creating .stack-size

ben via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 27 09:16:49 PDT 2018


bd1976llvm added a comment.

Hi Rafael,

Thanks for the reply. I agree that multiple sections is conceptually a
better
approach. Let's keep the discussion to the gabi list as it has nothing to do
with your change here.

> I will fix llvm to use multiple sections for -ffunction-sections/comdat

I agree with this and with the rest of your assessment in pr36717.

>   And there is no local symbol pouting the output. The assembler will

convert the reference to use section symbols.

I understand that and I thought your change was good. Apologies,
if "bloating" sounded bad I should have used "extra" instead. What I
meant was - wouldn't the assembly output have doubled up local/global
symbols? My idea is, could we find some way to not have to emit the
additional local symbols in the assembly file and hopefully to
remove the special case code in mc that is needed to emit them?


https://reviews.llvm.org/D44669





More information about the llvm-commits mailing list