[PATCH] D41330: [X86] Reduce Store Forward Block issues in HW

Nirav Dave via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 27 08:31:25 PDT 2018


niravd added a comment.

The changes from just https://reviews.llvm.org/D43619 look correct but I haven't looked deeply at this part of the patch. From the comments it looks like the patch is a bit out of date as std::map should have been converted back to switch statements.

Minor comment: I got tripped up on remembering what StoreForwardingBlock the first time I saw it. I think it Store-Forward Blocking is a more intuitive name than StoreForwardingBlock.


https://reviews.llvm.org/D41330





More information about the llvm-commits mailing list