[PATCH] D44928: [MC] Pass MCSubtargetInfo through to fixupNeedsRelaxation

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 27 08:13:54 PDT 2018


fhahn added a comment.

Thanks Peter! I think using the function attributes here makes a lot of sense.

Currently, `ARMAsmBackend` still has a `STI` member variable, which gets initialized when constructing the backend. At most places, the current `STI` passed in, but at some places (e.g. adjustFixupValue, line 592) still use the member variable. Are there use-cases where the initial `STI` contains the correct features, but the current `STI` does not?  I can't think of any off the top of my head and to avoid confusion over which `STI` is used, it might make sense to get rid of the member variable?


https://reviews.llvm.org/D44928





More information about the llvm-commits mailing list