[PATCH] D44782: Account for partial stack slot spills (PR30821)

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 27 03:27:28 PDT 2018


jmorse added inline comments.


================
Comment at: lib/Target/X86/X86InstrInfo.cpp:4270
+  case X86::VMOVDQU16Z256mr:
+    MemBytes = RegSize;
     return true;
----------------
craig.topper wrote:
> Why can't we always get this from the opcode or always from RegSize? What's the criteria for which way this is done? Why are the KMOV instructions implemented differently between Load and Store?
Ah, I'd incorrectly assumed that information wasn't in the opcode at this stage, which turns out to be wrong, I'll revise. As for the KMOVs, that's pure error alas.


Repository:
  rL LLVM

https://reviews.llvm.org/D44782





More information about the llvm-commits mailing list