[PATCH] D44772: [DWARF] Simplify DWARFAddressRange::contains

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 27 03:10:13 PDT 2018


jhenderson added a comment.

In https://reviews.llvm.org/D44772#1049012, @JDevlieghere wrote:

> In https://reviews.llvm.org/D44772#1048988, @jhenderson wrote:
>
> > LGTM. Any reason you decided not to change `intersects()`?
>
>
> Because we concluded that would not conform to the dwarf standard, right?


Right. I was just wondering whether the assert is needed in intersects (after the if, obviously), as well as contains. I think it's fine without it though.


Repository:
  rL LLVM

https://reviews.llvm.org/D44772





More information about the llvm-commits mailing list