[PATCH] D43962: [GlobalISel][utils] Adding the init version of Instruction Select Testgen

Roman Tereshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 16:47:11 PDT 2018


rtereshin added a comment.

In https://reviews.llvm.org/D43962#1048769, @aemerson wrote:

> Hi Roman,
>
> This is a very large patch with lots of complexity, and is hard to review. While your description outlines the general idea of the tool, there's little documentation in the code of how this actually works under the hood. Can you add more descriptions so someone can follow what's happening when it comes to maintenance later, e.g. what's LiveInRA supposed to do, what are the pre-conditions and expected outputs of each phase of this tool?
>
> Without that I suspect this patch will continue to lie in the review queue for a long while.
>
> Thanks,
> Amara


Hi Amara,

Thanks for taking a look at this! Will do.


Repository:
  rL LLVM

https://reviews.llvm.org/D43962





More information about the llvm-commits mailing list