[PATCH] D44898: [ELF] Fix incorrect deduplication of MergeSyntheticSection's

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

In https://reviews.llvm.org/D44898#1048688, @ruiu wrote:

> How much did Scylla get slower?
>
> > Maybe the best option is just disabling ICF of synthetic sections?
>
> That sounds like a better way of fixing the issue.


Yes, for large mergeable sections, this could significantly increase memory usage.

Disabling ICF for synthetic sections would be a way to fix the issue and I don't think it would have much negative impact in practice, i.e. ICF of these sections is not common.


https://reviews.llvm.org/D44898