[PATCH] D41674: [Support] CommandLine API -- Allow creating custom parsers for fundamental types

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 13:17:10 PDT 2018


chandlerc requested changes to this revision.
chandlerc added a comment.
This revision now requires changes to proceed.

I have a feeling that the original bug was from a time where we generally thought this side of commandline infrastructure was going to become a more broadly used way of building commandline tools with rich commandline interfaces. However, in recent years the project has gravitated towards the infrastructure in the `Option` library which is used by both Clang and LLD.

So, I'm personally not inclined to add more complexity to the commandline parsing logic. Is there a particular need that motivated this? I understand you wanted a `float` option, but for what purpose? Generally, we've been successful using basic integer ratios for debugging and testing options.


https://reviews.llvm.org/D41674





More information about the llvm-commits mailing list