[PATCH] D44868: [SLP] Distinguish "demanded and shrinkable" from "demanded and not shrinkable" values when determining the minimum bitwidth

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 10:21:49 PDT 2018


ABataev added inline comments.


================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4338
+        assert(R->hasOneUse() && "Root should have only one use!");
+        return isa<GetElementPtrInst>(*R->user_back());
+      })) {
----------------
Yuu don't need to dereference here if you're using `user_back()`


================
Comment at: test/Transforms/SLPVectorizer/AArch64/ext-trunc.ll:12-14
+; CHECK-NEXT:    [[Z0:%.*]] = zext <4 x i16> [[A:%.*]] to <4 x i32>
+; CHECK-NEXT:    [[Z1:%.*]] = zext <4 x i16> [[B:%.*]] to <4 x i32>
+; CHECK-NEXT:    [[SUB0:%.*]] = sub nsw <4 x i32> [[Z0]], [[Z1]]
----------------
Why you removed some checks generated by `utils/update_test_checks.py`?


Repository:
  rL LLVM

https://reviews.llvm.org/D44868





More information about the llvm-commits mailing list