[PATCH] D44868: [SLP] Distinguish "demanded and shrinkable" from "demanded and not shrinkable" values when determining the minimum bitwidth

Haicheng Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 09:22:30 PDT 2018


haicheng added inline comments.


================
Comment at: test/Transforms/SLPVectorizer/AArch64/ext-trunc.ll:1
+; RUN: opt -S -slp-vectorizer -instcombine < %s | FileCheck %s
+
----------------
lebedev.ri wrote:
> haicheng wrote:
> > ABataev wrote:
> > > 1. Commit this test separately as NFC with checks for the current version of the compiler.
> > > 2. Generate test checks using `utils/update_test_checks.py`
> > I will commit the separately.
> > > Commit this test separately as NFC with checks for the current version of the compiler.
> 
> > I will commit the separately.
> 
> What i think was meant is, commit the test now, and rebase the differential ontop of that commit,
> so the diff actually shows what this differential changes in the testcase.
Thank you for pointing this out.  I am working on it now.


Repository:
  rL LLVM

https://reviews.llvm.org/D44868





More information about the llvm-commits mailing list