[PATCH] D44898: [ELF] Fix incorrect deduplication of MergeSyntheticSection's

[Andrew Ng via Phabricator via llvm-commits]

andrewng added a comment.

In https://reviews.llvm.org/D44898#1048263, @espindola wrote:

> Seems reasonable.  I will just do a quick check on the performance impact.


Yes, that would be my only concern too, but I decided to keep it simple first.



================
Comment at: test/ELF/icf-not-equal-merged-sections.s:6
+
+# CHECK-NOT: selected section <internal>:(.rodata)
+
----------------
espindola wrote:
> The test would be a bit more dependable if you checked the content of the output with objdump/readelf/readobj.
> 
> As written the test would still pass if we changed the icf message and regressed this fix.
> 
Good point! I will look at adding this.


https://reviews.llvm.org/D44898