[llvm] r328386 - [X86] Fix Windows `i1 zeroext` conventions to use i8 instead of i32

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 26 03:13:23 PDT 2018


On Sat, Mar 24, 2018 at 12:38 AM, Reid Kleckner via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: rnk
> Date: Fri Mar 23 16:38:53 2018
> New Revision: 328386
>
> URL: http://llvm.org/viewvc/llvm-project?rev=328386&view=rev
> Log:
> [X86] Fix Windows `i1 zeroext` conventions to use i8 instead of i32
>
> Both GCC and MSVC only look at the low byte of a boolean when it is
> passed.
>
> Added:
>     llvm/trunk/test/CodeGen/X86/win32-bool.ll
>     llvm/trunk/test/CodeGen/X86/win64-bool.ll
> Modified:
>     llvm/trunk/lib/Target/X86/X86CallingConv.td
>     llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>     llvm/trunk/test/CodeGen/X86/avx512-intel-ocl.ll
>     llvm/trunk/test/CodeGen/X86/h-registers-0.ll
>     llvm/trunk/test/CodeGen/X86/test-shrink.ll
>     llvm/trunk/test/CodeGen/X86/vec_cast.ll
>     llvm/trunk/test/CodeGen/X86/xor.ll

This broke some tests in Chromium, so I've reverted in r328482. It
seems that Martin's patch in https://reviews.llvm.org/D44876 fixes the
problem, but since it's not reviewed yet I figured it would be best to
revert back to green in the meantime.


More information about the llvm-commits mailing list