[PATCH] D44791: [scudo] Fuchsia minimal shared runtime

[Petr Hosek via Phabricator via llvm-commits]

phosek added inline comments.


================
Comment at: lib/scudo/CMakeLists.txt:24
+  list(APPEND SCUDO_DYNAMIC_LIBS unwind_shared)
+endif()
+
----------------
You could add `RTSanitizerCommonCoverage`, `RTUbsan`, `RTUbsan_cxx` to a variable (e.g. `${SCUDO_EXTRA_OBJECT_LIBS}`) and `${SANITIZER_CXX_ABI_LIBRARY}` to `${SCUDO_DYNAMIC_LIBS}` in the else branch and then you don't need the two different branches for `add_compiler_rt_runtime(clang_rt.scudo ...)` below.


================
Comment at: lib/scudo/CMakeLists.txt:57
                 RTSanitizerCommonLibc
                 RTSanitizerCommonCoverage
                 RTInterception
----------------
Is this needed? I see it being included in `STATIC` library for all platforms and `SHARED` library for everything but Fuchsia. Is that correct?


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44791