[PATCH] D44853: [AArch64] Change std::sort to llvm::sort in response to r327219

Mandeep Singh Grang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 21:02:46 PDT 2018


mgrang added a comment.

In https://reviews.llvm.org/D44853#1047489, @rengolin wrote:

> I don't like this being on by default. I get it it uses `EXPENSIVE_CHECKS`, but still, most developers use Debug/Asserts builds.
>
> I think it's fine to have the `llvm::sort` in tree, but the patches that make use of it should be local, as they're use for specific investigations.
>
> Either that, or we replace *all* `std::sort` for `llvm:sort` and not just this one particular case.


This patch is one of a series of patches to replace *all* std::sort to llvm::sort in llvm/clang/polly (and other tools). I have a patch (https://reviews.llvm.org/D44363) which replaces all std::sort to llvm::sort. But as per review comments, it was suggested to break down that patch target-wise to smaller chunks. Hence I am now pushing smaller target-specific patches.


Repository:
  rL LLVM

https://reviews.llvm.org/D44853





More information about the llvm-commits mailing list