[lld] r328381 - Remove "FIXME" from a comment.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 15:48:17 PDT 2018


Author: ruiu
Date: Fri Mar 23 15:48:17 2018
New Revision: 328381

URL: http://llvm.org/viewvc/llvm-project?rev=328381&view=rev
Log:
Remove "FIXME" from a comment.

A bug in BFD linker is not our FIXME item.

Modified:
    lld/trunk/ELF/InputFiles.cpp

Modified: lld/trunk/ELF/InputFiles.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=328381&r1=328380&r2=328381&view=diff
==============================================================================
--- lld/trunk/ELF/InputFiles.cpp (original)
+++ lld/trunk/ELF/InputFiles.cpp Fri Mar 23 15:48:17 2018
@@ -861,13 +861,12 @@ template <class ELFT> void SharedFile<EL
       continue;
     }
 
-    if (Config->EMachine == EM_MIPS) {
-      // FIXME: MIPS BFD linker puts _gp_disp symbol into DSO files
-      // and incorrectly assigns VER_NDX_LOCAL to this section global
-      // symbol. Here is a workaround for this bug.
-      if (Versym && VersymIndex == VER_NDX_LOCAL && Name == "_gp_disp")
-        continue;
-    }
+    // MIPS BFD linker puts _gp_disp symbol into DSO files and incorrectly
+    // assigns VER_NDX_LOCAL to this section global symbol. Here is a
+    // workaround for this bug.
+    if (Config->EMachine == EM_MIPS && Versym && VersymIndex == VER_NDX_LOCAL &&
+        Name == "_gp_disp")
+      continue;
 
     const Elf_Verdef *Ver = nullptr;
     if (VersymIndex != VER_NDX_GLOBAL) {




More information about the llvm-commits mailing list