[PATCH] D44848: Align stubs for external and common global variables to pointer size.

Rahul Chaudhry via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 15:41:13 PDT 2018


rahulchaudhry added a comment.

In https://reviews.llvm.org/D44848#1047203, @mgrang wrote:

> Can you please add a unit test?


There is a minimized testcase in the bug report: https://bugs.llvm.org/show_bug.cgi?id=36885
I'm not sure which repo the test should be added to (llvm or clang?).
Should the test be generating asm or ll file and check for alignment directive on the stub?
It'll be useful if you can point me to an existing test that does something similar for regular (non-stub) symbols.
Any guidance will be appreciated. This is my first llvm change.


Repository:
  rL LLVM

https://reviews.llvm.org/D44848





More information about the llvm-commits mailing list