[PATCH] D44626: [InstCombine] Fold (A OR B) AND B code sequence over Phi node

Hiroshi Inoue via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 05:30:55 PDT 2018


inouehrs marked 2 inline comments as done.
inouehrs added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstCombinePHI.cpp:678
+    }
+  }
+  return nullptr;
----------------
majnemer wrote:
> I think you need to `return NewPhi`.
Thanks. I made the function return &Phi since we add (not replace) NewPhi or modify operands of Phi.


https://reviews.llvm.org/D44626





More information about the llvm-commits mailing list