[PATCH] D44806: [AMDGPU] MessagePack reader/writer

Nicolai Hähnle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 23 02:50:47 PDT 2018


nhaehnle added a comment.

Since MsgPack is certainly not AMDGPU-specific, this should go into a target-independent utils directory, possibly lib/Support/.

Also, where does the code come from? Unless you really reimplemented everything yourself, there should be a note about that. Also, it would be good to explain in the summary / commit message **why** we want to add this.


Repository:
  rL LLVM

https://reviews.llvm.org/D44806





More information about the llvm-commits mailing list