[PATCH] D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

One way that we could make forward progress without rewriting LLVM's linkage is to not apply .weak for `weak_odr` linkages. Then we'd say, `weak_odr` is exactly like `linkonce_odr` except it is non-discardable, pending a cleanup to make discardability a separate bit (probably along with a separate "odr" bit that informs the inliner and constant propagation). `weak` linkage would be reserved for things that truly use `__attribute__((weak))`.


Repository:
  rL LLVM

https://reviews.llvm.org/D44543