[PATCH] D44799: [sanitizer] Split stacktrace/symbolizer: Windows unwind

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm

I guess you are reusing the concept of `sanitizer_common_libcdep` even though these are not really libc dependencies.



================
Comment at: lib/sanitizer_common/sanitizer_unwind_win.cc:28
+#if !SANITIZER_GO
+  void BufferedStackTrace::SlowUnwindStack(uptr pc, u32 max_depth) {
+    CHECK_GE(max_depth, 2);
----------------
I don't think we indent for namespaces, do we? Besides, this is a method, we only need `using namespace __sanitizer;`.


https://reviews.llvm.org/D44799