[PATCH] D38792: Fix float literals under XO & fp-armv8

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 22 07:43:56 PDT 2018


SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

My remark about f16 values, and trying to trigger the assert, actually revealed some problems in lowering f16 constants. I am working on a fix now, but I don't see the point of holding back this patch. So this looks good to me, and if you put the assert back before committing, then we can pick up execute-only and f16 values later.


Repository:
  rL LLVM

https://reviews.llvm.org/D38792





More information about the llvm-commits mailing list