[PATCH] D44687: [SchedModel] Remove instregex entries that don't match any instructions (WIP)

[Javed Absar via Phabricator via llvm-commits]

javed.absar added a comment.

In https://reviews.llvm.org/D44687#1044554, @craig.topper wrote:

> This patch makes sure each regular expression covers at least one instruction. We already checked that each InstRW line matched at least one instruction. But if there were multiple regular expressions listed, we didn't check it.
>
> Making sure each instruction is only covered by one instregex or instrs match is already being done. And a hole in it was fixed recently with r327808. Though I had to disable the improved check on some models. Look for FullInstRWOverlapCheck = 0 in the SchedMachineModel in the td files to see if I disabled it for any schedulers you care about. I need to collect the effected schedulers and start getting people to fix it.


OK, I missed that. Please add R52 to your list.  FullInstRWOverlapCheck  idea is great. When there is overlap, would it be possible to check if the Defs are identical (less serious case) as opposed to two conflicting sched for same instruction? Sorry, maybe i should ask in a separate review (please point me to it).


Repository:
  rL LLVM

https://reviews.llvm.org/D44687