[llvm] r328155 - [WebAssembly] Really disable wasm register name matcher

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 14:46:47 PDT 2018


Author: rnk
Date: Wed Mar 21 14:46:47 2018
New Revision: 328155

URL: http://llvm.org/viewvc/llvm-project?rev=328155&view=rev
Log:
[WebAssembly] Really disable wasm register name matcher

The "ShouldEmitMatchRegisterName" bit wasn't taking effect because the
WebAssembly target didn't point to the custom WebAssemblyAsmParser
record.

Modified:
    llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
    llvm/trunk/lib/Target/WebAssembly/WebAssembly.td

Modified: llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp?rev=328155&r1=328154&r2=328155&view=diff
==============================================================================
--- llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp (original)
+++ llvm/trunk/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp Wed Mar 21 14:46:47 2018
@@ -32,10 +32,6 @@ using namespace llvm;
 
 #define DEBUG_TYPE "wasm-asm-parser"
 
-// TODO: TableGen generates this register name matcher, but it is not used
-// anywhere. Mark it with the "unused" attribute to suppress warnings.
-static unsigned LLVM_ATTRIBUTE_UNUSED MatchRegisterName(StringRef Name);
-
 namespace {
 
 // We store register types as SimpleValueType to retain SIMD layout

Modified: llvm/trunk/lib/Target/WebAssembly/WebAssembly.td
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssembly.td?rev=328155&r1=328154&r2=328155&view=diff
==============================================================================
--- llvm/trunk/lib/Target/WebAssembly/WebAssembly.td (original)
+++ llvm/trunk/lib/Target/WebAssembly/WebAssembly.td Wed Mar 21 14:46:47 2018
@@ -77,11 +77,12 @@ def : ProcessorModel<"bleeding-edge", No
 // Target Declaration
 //===----------------------------------------------------------------------===//
 
-def WebAssembly : Target {
-  let InstructionSet = WebAssemblyInstrInfo;
-}
-
 def WebAssemblyAsmParser : AsmParser {
   // The physical register names are not in the binary format or asm text
   let ShouldEmitMatchRegisterName = 0;
 }
+
+def WebAssembly : Target {
+  let InstructionSet = WebAssemblyInstrInfo;
+  let AssemblyParsers  = [WebAssemblyAsmParser];
+}




More information about the llvm-commits mailing list