[PATCH] D44415: [PM][FunctionAttrs] add NoUnwind attribute inference to PostOrderFunctionAttrs pass

Fedor Sergeev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 14:16:32 PDT 2018


fedor.sergeev marked an inline comment as done.
fedor.sergeev added inline comments.


================
Comment at: lib/Transforms/IPO/FunctionAttrs.cpp:1080
+
+    /// true for "valid" attributes that went through at least one instruction
+    /// scan
----------------
jlebar wrote:
> Capital
I wonder if capitalizing "true" which is a boolean value and not an English word here is fine?


Repository:
  rL LLVM

https://reviews.llvm.org/D44415





More information about the llvm-commits mailing list