[PATCH] D44713: Unsubmitted part of D44599

[David CARLIER via Phabricator via llvm-commits]

devnexen added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_linux.cc:404
 #if SANITIZER_USES_CANONICAL_LINUX_SYSCALLS || SANITIZER_OPENBSD
-  return internal_syscall(SYSCALL(unlinkat), AT_FDCWD, (uptr)path, 0);
+  return internal_syscall_ptr(SYSCALL(unlinkat), AT_FDCWD, (uptr)path, 0);
 #else
----------------
vitalybuka wrote:
> devnexen wrote:
> > vitalybuka wrote:
> > > same for unlinkat, it returns int, on both
> > > 
> > Seems under Linux it s the same in fact https://github.com/llvm-mirror/compiler-rt/blob/b4e600115ad4c50192095c225aaed3ae9ca99ec1/lib/sanitizer_common/sanitizer_syscall_generic.inc#L53 but I personally do not mind reverting them I think it was kamel who asked me to update in the first place.
> it's the same, but if we introduced internal_syscall_ptr and we specified that it's for pointers and size, we should follow that convention.
Good enough for me.


https://reviews.llvm.org/D44713