[PATCH] D44579: [asan] Clean up some confusing code in `test/asan/TestCases/Darwin/segv_read_write.c`

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 12:42:05 PDT 2018


eugenis added a comment.

The comment makes sense to me. Writes are instrumented with reads from shadow in ASan. Therefore a write to addr in shadow will result in a read from shadow(addr), which is located in the mprotect-ed shadow gap, and will be reported as a read SEGV, not a write SEGV.

mmap() argument change looks fine.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44579





More information about the llvm-commits mailing list