[PATCH] D44682: [ELF] Fix X86 & X86_64 PLT retpoline padding

[Rafael Avila de Espindola via Phabricator via llvm-commits]

espindola added a comment.

> The current behaviour is only to fill the last page of executable segments with trap instructions. So even in the non linker script case, there still could be zero rather than trap instruction padding in the PLT. I don't know how big an issue this really is, but it feels better to be padding with trap instructions.

OK, I think there is a far more general issue at play:

https://bugs.llvm.org/show_bug.cgi?id=36853

We should probably fix the non linkerscript non --no-rosegment case first and see if it covers this too.


https://reviews.llvm.org/D44682