[PATCH] D44733: Split the `throw_invoke_test.cc` test

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 21 07:31:05 PDT 2018


delcypher added a comment.

In https://reviews.llvm.org/D44733#1044382, @Hahnfeld wrote:

> Hmm, that's basically duplicating the test case. Maybe you can `#include "../throw_invoke_test.cc"`?


I actually did that originally but I decided I didn't like it because it creates a dependency between the two test files. I don't think there's any precedence for doing that.

I'll let @kcc have the final say as this is his test case originally.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D44733





More information about the llvm-commits mailing list