[PATCH] D43219: [PartialInlining] Fix Crash from holding a reference to a destructed ORE

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 18:30:22 PDT 2018


sfertile added a comment.

In https://reviews.llvm.org/D43219#1043457, @graham-yiu-huawei wrote:

> @sfertile Sorry for the late response.  AFAIK there shouldn't be a downside to creating the ORE objects at the point of use, I only did it the original way to conform to the style I saw in other passes and to avoid passing the ORE object from function to function.  However, my knowledge in the ORE area is limited so someone else may contradict what I just said.  Good luck!


np Graham, I appreciate you taking the time to look at this again.


Repository:
  rL LLVM

https://reviews.llvm.org/D43219





More information about the llvm-commits mailing list