[llvm] r328065 - Move DataTypes.h from Support to llvm-c to fix layering.

Friedman, Eli via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 18:01:27 PDT 2018


On 3/20/2018 5:48 PM, David Blaikie via llvm-commits wrote:
> Author: dblaikie
> Date: Tue Mar 20 17:48:05 2018
> New Revision: 328065
>
> URL: http://llvm.org/viewvc/llvm-project?rev=328065&view=rev
> Log:
> Move DataTypes.h from Support to llvm-c to fix layering.
>
> Support depends on llvm-c (a few typedefs, macros, etc - Types.h,
> Disassembler.h, and TargetMachine.h.
>
> This could be done the other way - those macros/typedefs/etc could be
> moved into Support and used from llvm-c instead. If someone feels that's
> a better direction to go, happy to discuss it/try it out/etc.

This seems backwards.

include/llvm-c/* is the C API wrapper, which allows code written in 
languages other than C++ to call LLVM APIs.  There shouldn't be any 
dependencies from include/llvm/* to include/llvm-c/*.

-Eli

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project



More information about the llvm-commits mailing list