[PATCH] D44717: [InstrProf] Support for external functions in text format.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 16:55:01 PDT 2018


mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: include/llvm/ProfileData/InstrProf.h:430
+
+  static StringRef getExternalSymbol() {
+    return "__llvm_prof_external_symbol__";
----------------
davidxl wrote:
> Why do we need to do this? Is it better to return an empty string and skip the entry when it is empty?
Just to distinguish it from an erroneous input.


Repository:
  rL LLVM

https://reviews.llvm.org/D44717





More information about the llvm-commits mailing list