[PATCH] D44562: [ELF] Rework debug line parsing to use llvm::Error and callbacks (LLD-side)

Rafael Avila de Espindola via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 15:50:21 PDT 2018


espindola added a comment.

In https://reviews.llvm.org/D44562#1042990, @jhenderson wrote:

> @rafael on the mailing list:
>
> > Now that I think of it, the fact that lld could not parse the debug info to provide a better error message should always be a note, not an error, regardless of how broken the section happens to be.
>
> To be clear, are you saying you're happy with the warnings for now, or would you prefer to drop the severity to just use "message()"? Also, what do you think about the generic error type which currently emits an error? I'd be happy to change the severity of that one too. It's currently an error because we don't expect an Error of that type ever to be reported.


Using message() in all cases seems better.  We know the link is failing for unrelated reasons and we are just letting the user know why we are not printing better error messages (could not parse the debug info).


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44562





More information about the llvm-commits mailing list