[PATCH] D44690: [ELF] Simplify compCtors and writeInt.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 11:10:06 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rLLD328009: [ELF] Simplify compCtors and writeInt. (authored by MaskRay, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D44690?vs=139149&id=139166#toc

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D44690

Files:
  ELF/OutputSections.cpp


Index: ELF/OutputSections.cpp
===================================================================
--- ELF/OutputSections.cpp
+++ ELF/OutputSections.cpp
@@ -25,7 +25,6 @@
 using namespace llvm;
 using namespace llvm::dwarf;
 using namespace llvm::object;
-using namespace llvm::support::endian;
 using namespace llvm::ELF;
 
 using namespace lld;
@@ -213,11 +212,11 @@
   if (Size == 1)
     *Buf = Data;
   else if (Size == 2)
-    write16(Buf, Data, Config->Endianness);
+    write16(Buf, Data);
   else if (Size == 4)
-    write32(Buf, Data, Config->Endianness);
+    write32(Buf, Data);
   else if (Size == 8)
-    write64(Buf, Data, Config->Endianness);
+    write64(Buf, Data);
   else
     llvm_unreachable("unsupported Size argument");
 }
@@ -366,8 +365,6 @@
   assert(Y.startswith(".ctors") || Y.startswith(".dtors"));
   X = X.substr(6);
   Y = Y.substr(6);
-  if (X.empty() && Y.empty())
-    return false;
   return X < Y;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D44690.139166.patch
Type: text/x-patch
Size: 939 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180320/0bdc6da8/attachment.bin>


More information about the llvm-commits mailing list