[PATCH] D44360: [compiler-rt] Change std::sort to llvm::sort in response to r327219
Mandeep Singh Grang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Mar 20 10:52:48 PDT 2018
mgrang added a comment.
In https://reviews.llvm.org/D44360#1042816, @kcc wrote:
> Also: this change has been committed w/o an approval from any of the
> owners.
> please try to avoid this in future.
>
> --kcc
Sure. I would keep that in mind. Thanks!
Also, since compiler-rt can be built outside of the llvm tree, I guess we cannot depend on the invocation of llvm::sort. So I guess compiler-rt cannot use the "shuffle before sort" infrastructure of llvm? Could you please comment on whether this is correct? Is there any way we can use llvm::sort for compiler-rt?
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D44360
More information about the llvm-commits
mailing list