[PATCH] D44469: [llvm-readobj] - Teach llvm-readobj to dump .note.gnu.property sections.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 20 04:03:15 PDT 2018


grimar added inline comments.


================
Comment at: test/tools/llvm-readobj/note-gnu-property.s:15
+// CHECK-NEXT:     no copy on protected: pr_datasz (0x00000001) is corrupted
+// CHECK-NEXT:     <unexpected end of property declaration>
+
----------------
espindola wrote:
> Shouldn't this cause llvm-readobj to exit with a non-0 value?
I think no, because Binutils readelf return 0 in this case.

Though it reports things in a slightly different format:
```
      Properties: stack size: 0x100
	stack size: <corrupt length: 0x4> 
	no copy on protected 
	<application-specific type 0xfefefefe data: >
	stack size: <corrupt length: 0> 
	no copy on protected <corrupt length: 0x1> 
	<corrupt type (0x2) datasz: 0x1>
```

I updated the patch to follow.


https://reviews.llvm.org/D44469





More information about the llvm-commits mailing list