[PATCH] D42898: Do not spill CSR to stack on entry to noreturn functions

[Eric Christopher via Phabricator via llvm-commits]

echristo added a comment.

Other than an inline comment (of no consequence) this looks like it's probably ok here. The naming of the function isn't great (welcome to fabulous bikesheds in programming), but I don't have a better idea off the top of my head so let's go with that.

Since Eli had already started a review let's give him a bit of time (Or Matthias) after this email to take a last look, otherwise I'll approve next week.

Thanks!

-eric



================
Comment at: lib/Target/ARM/ARMFrameLowering.cpp:95
+  // can always skip CSR saves for nonreturning functions.
+  return true;
+}
----------------
I'd probably like to see an assert here (and in the general case) that we've got a noreturn and nounwind function.


Repository:
  rL LLVM

https://reviews.llvm.org/D42898